[Intel-gfx] [PATCH 1/2] intel: Add support for overriding the PCI ID via an environment variable

[Julien Cristau]

On Tue, Feb 21, 2012 at 21:11:07 +0000, Chris Wilson wrote:

> On Tue, 21 Feb 2012 12:59:37 -0800, Kenneth Graunke <kenneth at whitecape.org> wrote:
> > @@ -1828,6 +1829,9 @@ drm_intel_gem_bo_mrb_exec2(drm_intel_bo *bo, int used,
> >  	execbuf.rsvd1 = 0;
> >  	execbuf.rsvd2 = 0;
> >  
> > +	if (getenv("INTEL_DEVID_OVERRIDE"))
> > +		goto skip_execution;
> 
> I'm not thrilled about calling getenv() for every execbuffer. And what
> about the original execbuffer path?

I'm not thrilled about allowing the user to modify X server behaviour
with an env variable.  This is setuid root after all.  I guess this also
applies to the existing calls to getenv in the dri driver.

Cheers,
Julien