[Intel-gfx] [PATCH] xf86-video-intel: Add support for toshiba backlight interface

[Akio Idehara]

Seth Forshee wrote:

> On Wed, Mar 14, 2012 at 11:37:39PM +0900, Akio Idehara wrote:
>> xfce4-power-manager cannot control backlight brightness via
>> toshiba backlight sysfs interface.
>> The reason is that xf86-video-intel doesn't treat it.
>> This patch adds support for toshiba backlight sysfs interface.
>>
>> This was tested on a Toshiba Portege R500.
>>
>> Signed-off-by: Akio Idehara <zbe64533 at gmail.com>
> 
> This isn't a good idea. On many (probably most) Toshibas the platform
> backlight interface is read-only. I think this patch will break more
> machines than it fixes.
> 
> I have a patch for toshiba_acpi that (among other things) makes it only
> register the backlight device if it can be written. I've just been
> sitting on it though because I haven't been able to get anyone with a
> read/write backlight interface to test it. If you'd be willing to help
> with testing then I can work on getting that patch into the kernel, then
> I wouldn't object to your patch.
> 
> Seth
> 


Hi Seth.

Thank you for telling me about this.
If I had known it, I'd never send this patch.
And I'd be happy to help with testing.
So please feel free to send me your patch!

Regards,
Akio