[Intel-gfx] [PATCH 1/2] drm/i915: Add BUG_ON when ring->private is NULL

Daniel Vetter daniel at ffwll.ch
Sun Mar 18 19:09:55 CET 2012


On Fri, Mar 16, 2012 at 12:43:21PM -0400, Sean Paul wrote:
> I have experienced a number of NULL pointer dereferences on
> suspend/resume where ring->private is NULL. These come from failed
> initialization of the ring buffer. Sincce this doesn't seem to be easily
> recoverable, this patch adds a BUG_ON and a bread crumb pointer for
> people who might encounter this in the future.
> 
> Signed-off-by: Sean Paul <seanpaul at chromium.org>
Chris shot this down on irc, BUG_ON isn't really more useful than a NULL
pointer oops. I agree, so I've dropped this from -next.
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48



More information about the Intel-gfx mailing list