[Intel-gfx] [PATCH 1/2] drm/i915: Check VBIOS value for determining LVDS dual channel mode, too

Rodrigo Vivi rodrigo.vivi at gmail.com
Tue Mar 20 19:35:35 CET 2012


Altough Keith's idea is very good I tested here with many systems that
are already working nowadays and it didn't break anything. Including
atom at 945gme, ironlake, sandybridge and ivybridge... including
single and dual channel modes...

Tested-by: Rodrigo Vivi <rodrigo.vivi at gmail.com>

On Tue, Mar 20, 2012 at 11:57 AM, Keith Packard <keithp at keithp.com> wrote:
> <#part sign=pgpmime>
> On Tue, 20 Mar 2012 13:04:41 +0100, Takashi Iwai <tiwai at suse.de> wrote:
>
>> Since checking the lid state is tricky and unreliable, the practical
>> check would be simply reading the first LVDS reg and seeing whether it
>> was initialized or not.  It seems that it reads to 0x02 when booted
>> with the lid close, which is LVDS_DETECTED bit.
>
> Right, lid-detect is not useful, so I suggested using the new code path
> only if the LVDS was *not* actually running at startup time. That should
> avoid almost all common cases that work correctly today.
>
> --
> keith.packard at intel.com
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
GPG: 0x905BE242 @ wwwkeys.pgp.net



More information about the Intel-gfx mailing list