[Intel-gfx] [PATCH 02/25] drm/i915: add debug message when EDID fetch fails

[Jesse Barnes]

On Wed, 21 Mar 2012 17:44:12 -0300
Eugeni Dodonov <eugeni at dodonov.net> wrote:

> On Wed, Mar 21, 2012 at 16:48, Jesse Barnes <jbarnes at virtuousgeek.org>wrote:
> 
> > +       } else {
> 
> +               DRM_DEBUG_KMS("failed to fetch edid\n");
> >        }
> >
> 
> 
> Wouldn't it be prettier if we also add some:
>    ...
>    err = -ENXIO;
> 
> or similar error in that block, to let the caller know that we failed as
> well?
> 
> 
> >        return ret;
> >
> 

Maybe but I think most callers just check for the EDID later anyway.

Really this patch can be dropped, but I was wondering exactly where the
GPIO side of things was failing and added some debug output...

-- 
Jesse Barnes, Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120321/49b5bf17/attachment.sig>