[Intel-gfx] [PATCH 18/26] drm/i915: add ValleyView specific CRT detect function
eugeni at dodonov.net
Fri Mar 23 18:11:44 CET 2012
On Thu, Mar 22, 2012 at 18:39, Jesse Barnes <jbarnes at virtuousgeek.org>wrote:
> Might be able to merge this back in at some point, but we're seeing bugs
> with ADPA based detection, so keep it separate for now with explicit
> hotplug trigger usage.
> v2: drop superfluous debug message
> + DRM_DEBUG_KMS("valleyview hotplug adpa=0x%x, result %d\n", adpa,
> + ret = true;
I think this is on purpose, to be able to debug it further, but maybe it
would be worth to remove this assignment from this function and add a check
for real return code into intel_crt_detect_hotplug() block? Or maybe add a
/* FIXME */ comment at least? Otherwise, it feel that it could be too
error-prone to leave this assignment here by itself.
Other than that, it looks correct to me.
Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com>
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Intel-gfx