[Intel-gfx] [PATCH 13/16] drm/i915: extract copy helpers from shmem_pread|pwrite

Chris Wilson chris at chris-wilson.co.uk
Mon Mar 26 11:05:39 CEST 2012


On Sun, 25 Mar 2012 19:47:40 +0200, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> While moving around things, this two functions slowly grew out of any
> sane bounds. So extract a few lines that do the copying and
> clflushing. Also add a few comments to explain what's going on.
> 
> v2: Again do s/needs_clflush/needs_clflush_after/ in the write paths
> as suggested by Chris Wilson.
> 
> Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

I've tested up to this point and have no further comments to make. (Ok,
there is the s/claring/glaring/ spelling mistake ;-)

1-13:
  Tested-by: Chris Wilson <chris at chris-wilson.co.uk>
  Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

And it turns out I've never used swizzled pwrites. ;)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list