[Intel-gfx] [PATCH 16/26] agp/intel: add ValleyView AGP driver

Ben Widawsky ben at bwidawsk.net
Mon Mar 26 20:17:33 CEST 2012

On Mon, Mar 26, 2012 at 09:08:28AM +0200, Daniel Vetter wrote:
> On Sun, Mar 25, 2012 at 07:16:31PM -0700, Ben Widawsky wrote:
> > I'm pretty torn about whether or not we actually want to use .gen=7
> > (both here and in the other patch). But if it's what you think is best,
> > let's do it.
> gen here is only used in the intel-gtt code. I expect it's prette
> irrelevant (haven't checked though).
> > do you really want gen6_check_flags? or i830_check_flags?
> > FWIW, I have no clue why we even need check_flags()
> Backwards compat for tha fake agp interface. We don't use it and hence
> it's totally irrelevant. We really should reap all this crap for gen6+ at
> least.

It seemed like we gained nothing by doing this, when I looked

> -Daniel

More information about the Intel-gfx mailing list