[Intel-gfx] [PATCH 04/18] drm/i915: add context information to objects
ben at bwidawsk.net
Thu Mar 29 02:20:11 CEST 2012
On Thu, 29 Mar 2012 00:36:21 +0200
Daniel Vetter <daniel at ffwll.ch> wrote:
> On Sun, Mar 18, 2012 at 01:39:44PM -0700, Ben Widawsky wrote:
> > Handy mostly for assertions.
> > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> I don't see the point of carrying around a obj->context_id -
> context_id's are file_priv, so they're not that useful in the
> tracepoint. I suggest you just drop the contex_id arg there - the obj
> pointers are global and imo good enough for identification. And the
> few BUG_ON's don't seem really useful either.
obj->context_id was requested by Chris to clarify the trace events. I
vaguely recall telling him that you won't like it.
I personally dislike using object pointer though I do agree it serves
the same purpose.
The other nice thing about having the context id is it makes it easy in
debug situations to find out if a certain object is a context object.
But no use case for that yet.
More information about the Intel-gfx