[Intel-gfx] [PATCH 3/3] drm/i915: extract gt interrupt handler

Jesse Barnes jbarnes at virtuousgeek.org
Fri Mar 30 20:28:40 CEST 2012

On Fri, 30 Mar 2012 20:24:35 +0200
Daniel Vetter <daniel.vetter at ffwll.ch> wrote:

> vlv, ivb and snb all share the gen6+ gt irq handling. 3 copies of the
> same stuff is a bit much, so extract it into a little helper.
> Now ilk has a different gt irq handling than snb, but shares the same
> irq handler (due to the similar display block). So also extract the
> ilk gt irq handling to clearly separate these two things.
> Nice side effect of this is that we can complete Ben Widawsky's gen6+
> irq bit #define cleanup and call the render irq also with the GEN6
> alias. Beforehand that code was shared with ilk, and neither option
> really made much sense.
> As a bonus this enables the error interrupt handling lifted from the
> vlv code on snb and ivb, too.
> Signed-Off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Nice cleanup.  Though I don't really like the IS_GEN5 branch in
ironlake_irq_handler... might be nicer to just bite the bullet and have
a mostly duplicate snb irq handler.

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

Jesse Barnes, Intel Open Source Technology Center
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120330/d29c88e6/attachment.sig>

More information about the Intel-gfx mailing list