[Intel-gfx] [PATCH 09/12] drm/i915: disable the infoframe before changing it

[Eugeni Dodonov]

On Wed, May 2, 2012 at 10:55 PM, Paulo Zanoni <przanoni at gmail.com> wrote:

> From: Paulo Zanoni <paulo.r.zanoni at intel.com>
>
> That's what the VIDEO_DIP_CTL documentation says we need to do. Except
> when it's the AVI InfoFrame and we're ironlake_write_infoframe.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
>

Reviewed-by: Eugeni Dodonov <eugeni.dodonov at intel.com>


>        val &= ~(VIDEO_DIP_SELECT_MASK | 0xf); /* clear DIP data offset */
>        val |= intel_infoframe_index(frame);
>
> +       if (frame->type == DIP_TYPE_AVI)
> +               val |= VIDEO_DIP_ENABLE_AVI;
> +       else
> +               val &= ~intel_infoframe_enable(frame);
> +
>

Maybe adding a comment here saying why we have this on Ironlake as well?

-- 
Eugeni Dodonov
<http://eugeni.dodonov.net/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120503/bc1342a9/attachment.html>