[Intel-gfx] [PATCH 04/14] drm/i915: touch the DIP control register after enabling the HDMI port

[Daniel Vetter]

On Tue, May 08, 2012 at 01:59:50PM +0200, Daniel Vetter wrote:
> On Fri, May 04, 2012 at 05:18:16PM -0300, Paulo Zanoni wrote:
> > From: Paulo Zanoni <paulo.r.zanoni at intel.com>
> > 
> > This is not documented anywhere, but it seems necessary to make the
> > InfoFrames work, especially when all you have is an HDMI monitor.
> > 
> > Some bugs get fixed just by running "./intel_infoframes -d". This
> > patch fixes this problem on my machine.
> > 
> > Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> 
> Can you elaborate a bit on which machines really need this? I fear that
> we're adding a hack here which is only required on a few chips and then
> keep it around forever ...

While reviewing the ilk dip port select change (and looking at gm45 bspec,
too) I've noticed that bspec says we can't change the port while the DIP
stuff is enabled. Could it be that we need to properly disable DIP on dpms
off to ensure that the hw doesn't get confused? We do rewrite all
infoframes in mode_set anyway ...
-Daniel
-- 
Daniel Vetter
Mail: daniel at ffwll.ch
Mobile: +41 (0)79 365 57 48