[Intel-gfx] [PATCH 2/2] drm/i915: Enable the PCH PLL for all generations after link training

[Eugeni Dodonov]

On Sun, May 13, 2012 at 8:35 PM, Eugeni Dodonov <eugeni at dodonov.net> wrote:

> On Sun, May 13, 2012 at 5:54 AM, Chris Wilson <chris at chris-wilson.co.uk>wrote:
>
>> +       intel_enable_pch_pll(intel_crtc);
>> +
>>        if (HAS_PCH_LPT(dev)) {
>>                DRM_DEBUG_KMS("LPT detected: programming iCLKIP\n");
>>                lpt_program_iclkip(crtc);
>>        } else if (HAS_PCH_CPT(dev)) {
>>
>
> Could we just replace this 'else if()' with 'else' to achieve the same
> functionality? This way, everything will work and we won't touch wrong
> registers on LPT.
>

Err, English fail here from my side. What I thought was:

       if (HAS_PCH_LPT(dev)) {
               DRM_DEBUG_KMS("LPT detected: programming iCLKIP\n");
               lpt_program_iclkip(crtc);
       } else
               intel_enable_pch_pll(intel_crtc);

if (HAS_PCH_CPT(dev)) {
       u32 sel;
       temp = I915_READ(PCH_DPLL_SEL);
       switch (pipe) {
       default:
...

-- 
Eugeni Dodonov
<http://eugeni.dodonov.net/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120513/2acfb0cb/attachment.html>