[Intel-gfx] [PATCH 4/4] drm/i915: don't rewrite the GTT on resume v3

Jesse Barnes jbarnes at virtuousgeek.org
Fri Nov 2 17:40:47 CET 2012


On Fri, 02 Nov 2012 15:16:36 +0000
Chris Wilson <chris at chris-wilson.co.uk> wrote:

> On Wed, 31 Oct 2012 15:41:05 -0700, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> > The BIOS shouldn't be touching this memory across suspend/resume, so
> > just leave it alone.  This saves us ~6ms on resume on my T420 (retested
> > with write combined PTEs).
> > 
> > v2: change gtt restore default on pre-gen4 (Chris)
> >     move needs_gtt_restore flag into dev_priv
> > v3: make sure we restore GTT on resume from hibernate (Daniel)
> >     use opregion support as the cutoff for restore from resume (Chris)
> > 
> > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> 
> My troublesome PNV of yore remains happy with this patch, so
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> 
> Bikeshed: intel_bios_has_opregion(), as we test for this in different
> locations in different ways.
> -Chris
> 

Ended up using dev_priv->opregion.header as the check, seems simplier.

Integrated your other comments and reposted a new series.

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list