[Intel-gfx] intel-gpu-tools: --disable-tests option should make cairo-check obsolete

[Sedat Dilek]

On Wed, Aug 14, 2013 at 11:03 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Wed, Aug 14, 2013 at 10:33:42PM +0200, Sedat Dilek wrote:
>> Hi,
>>
>> I am here on Ubuntu/precise and wanted to avoid to upgrade to a higher
>> cairo-version.
>
> Daniel's position is that he wants to make it hard for QA to build the
> tests incorrectly and so skip half of them. I think defaulting to
> erroring out at configure if cairo is too old, but allowing an explicit
> --disable-cairo should make all us happy.

Hmm, just curious how this should work?

Beyond testdisplay... kms_flip and kms_render tests require cairo.h
include - not sure which version of cairo is minimum.
So, --disable-cairo configure-option should disable above tests?

[ tests/Makefile.am ]
...
testdisplay_SOURCES = \
        testdisplay.c \
        testdisplay.h \
        testdisplay_hotplug.c \
        $(NULL)

TESTS_progs += testdisplay
LDADD += $(CAIRO_LIBS) $(LIBUDEV_LIBS) $(GLIB_LIBS)
AM_CFLAGS += $(CAIRO_CFLAGS) $(LIBUDEV_CFLAGS) $(GLIB_CFLAGS)
...

$ grep -i cairo.h -nr ./
./lib/drmtest.h:34:#include <cairo.h>
./tests/kms_flip.c:28:#include <cairo.h>
./tests/kms_render.c:27:#include <cairo.h>
./tests/testdisplay.c:52:#include <cairo.h>

Thanks in advance.

- Sedat -