[Intel-gfx] [PATCH] drm/i915: dump adjusted crtc timings

Daniel Vetter daniel.vetter at ffwll.ch
Mon Aug 19 10:57:21 CEST 2013


I always wondered how the pipe config compare could work with an
all-zero mode. Now I've finally realized that we read out the crtc
timings, but drm_mode_debug_printmodeline prints out the original
mode, which we don't reconstruct. And which is also rather irrelevant
when computing the pipe config.

So switch over to dumping just the raw hw timings when printing the
adjusted mode.

Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
---
 drivers/gpu/drm/i915/intel_display.c |   13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index be79f47..a4f44f3 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -7738,6 +7738,8 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
 				   struct intel_crtc_config *pipe_config,
 				   const char *context)
 {
+	struct drm_display_mode *mode;
+
 	DRM_DEBUG_KMS("[CRTC:%d]%s config for pipe %c\n", crtc->base.base.id,
 		      context, pipe_name(crtc->pipe));
 
@@ -7752,8 +7754,15 @@ static void intel_dump_pipe_config(struct intel_crtc *crtc,
 		      pipe_config->fdi_m_n.tu);
 	DRM_DEBUG_KMS("requested mode:\n");
 	drm_mode_debug_printmodeline(&pipe_config->requested_mode);
-	DRM_DEBUG_KMS("adjusted mode:\n");
-	drm_mode_debug_printmodeline(&pipe_config->adjusted_mode);
+	mode = &pipe_config->adjusted_mode;
+	DRM_DEBUG_KMS("adjusted mode timings:\n");
+	DRM_DEBUG_KMS("adjusted mode timings: %d %d %d %d %d %d %d %d %d "
+			"0x%x 0x%x\n",
+		mode->clock,
+		mode->crtc_hdisplay, mode->crtc_hsync_start,
+		mode->crtc_hsync_end, mode->crtc_htotal,
+		mode->crtc_vdisplay, mode->crtc_vsync_start,
+		mode->crtc_vsync_end, mode->crtc_vtotal, mode->type, mode->flags);
 	DRM_DEBUG_KMS("gmch pfit: control: 0x%08x, ratios: 0x%08x, lvds border: 0x%08x\n",
 		      pipe_config->gmch_pfit.control,
 		      pipe_config->gmch_pfit.pgm_ratios,
-- 
1.7.10.4




More information about the Intel-gfx mailing list