[Intel-gfx] [PATCH 10/15] drm/i915: remove extra clearing of GTIIR from VLV irq preinstall

Paulo Zanoni przanoni at gmail.com
Wed Jul 24 00:33:50 CEST 2013


From: Paulo Zanoni <paulo.r.zanoni at intel.com>

After the last changes, gen5_gt_irq_preinstall should now guarantee
that GTIIR will be zero. Also, at valleyview_irq_postinstall we call
gen5_gt_irq_postinstall which calls intel_irq_reg_init, which will
print a nice WARN in case GTIIR is not zero.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 5ca50a0..9684f1e 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -2056,10 +2056,6 @@ static void valleyview_irq_preinstall(struct drm_device *dev)
 	I915_WRITE(RING_IMR(GEN6_BSD_RING_BASE), 0);
 	I915_WRITE(RING_IMR(BLT_RING_BASE), 0);
 
-	/* and GT */
-	I915_WRITE(GTIIR, I915_READ(GTIIR));
-	I915_WRITE(GTIIR, I915_READ(GTIIR));
-
 	gen5_gt_irq_preinstall(dev);
 
 	I915_WRITE(DPINVGTT, 0xff);
-- 
1.8.1.2




More information about the Intel-gfx mailing list