[Intel-gfx] [PATCH 09/15] drm/i915: remove additional zerogin of VLV_IIR at postinstall

Paulo Zanoni przanoni at gmail.com
Wed Jul 24 00:33:49 CEST 2013


From: Paulo Zanoni <paulo.r.zanoni at intel.com>

There is no comment explaining why it's needed and I don't see a
reason for it to exist. Also, a few lines above we call
INTEL_IRQ_REG_INIT and pass VLV_IIR, so we should print a WARN in case
VLV_IIR is not zero at that point.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 6793b30..5ca50a0 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -2244,9 +2244,6 @@ static int valleyview_irq_postinstall(struct drm_device *dev)
 	i915_enable_pipestat(dev_priv, 1, pipestat_enable);
 	spin_unlock_irqrestore(&dev_priv->irq_lock, irqflags);
 
-	I915_WRITE(VLV_IIR, 0xffffffff);
-	I915_WRITE(VLV_IIR, 0xffffffff);
-
 	gen5_gt_irq_postinstall(dev);
 
 	/* ack & enable invalid PTE error interrupts */
-- 
1.8.1.2




More information about the Intel-gfx mailing list