[Intel-gfx] [PATCH 08/10] drm/i915: Don't try to calculate RC6 residency on GEN4 and before

Paulo Zanoni przanoni at gmail.com
Tue Jun 11 21:33:24 CEST 2013


2013/6/7 Damien Lespiau <damien.lespiau at intel.com>:
> intel_enable_rc6() is used to check if we can compute the RC6 residency
> in the sysfs code. Disable this for platforms older than Ironlake.
>
> Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_pm.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 2eb1846..0465cd6 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -3154,6 +3154,10 @@ static void valleyview_disable_rps(struct drm_device *dev)
>
>  int intel_enable_rc6(const struct drm_device *dev)
>  {
> +       /* No RC6 before Ironlake */
> +       if (INTEL_INFO(dev)->gen < 5)
> +               return 0;

Daniel recently complained about a similar check on one of my patches.
Looks like the preferred way would be "if (INTEL_INFO(dev)->gen <=
4)". I guess Daniel can do this change while applying the patch.

Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>

> +
>         /* Respect the kernel parameter if it is set */
>         if (i915_enable_rc6 >= 0)
>                 return i915_enable_rc6;
> --
> 1.8.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx



-- 
Paulo Zanoni



More information about the Intel-gfx mailing list