[Intel-gfx] [PATCH 08/24] drm/i915: fix hpd interrupt register locking

[Daniel Vetter]

On Wed, Jun 12, 2013 at 4:59 PM, Egbert Eich <eich at suse.com> wrote:
>  > +    assert_spin_locked(&dev_priv->irq_lock);
>  > +
>  >      if (I915_HAS_HOTPLUG(dev)) {
>  >              hotplug_en = I915_READ(PORT_HOTPLUG_EN);
>  >              hotplug_en &= ~HOTPLUG_INT_EN_MASK;
>
>
> Didn't you want to do the same for ibx_hpd_irq_setup() ?

Will happen in a follow-up patch, since I first consolidate all access
to SDEIMR into one single helper function. I've tried to explain that
a bit in the commit message but failed to make the connection to
ibx_hpd_irq_setup - once we have the helper function the
assert_spin_locked is in there and so ibx_hpd_irq_setup doesn't need
its own check (since it won't touch SDEIMR directly any more).
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch