[Intel-gfx] [PATCH] drm/i915: replace snb_update_wm with haswell_update_wm on HSW

Daniel Vetter daniel at ffwll.ch
Sat May 25 18:01:11 CEST 2013

On Fri, May 24, 2013 at 6:20 PM, Ville Syrjälä
<ville.syrjala at linux.intel.com> wrote:
> On Fri, May 24, 2013 at 06:13:15PM +0200, Daniel Vetter wrote:
>> On Fri, May 24, 2013 at 6:07 PM, Daniel Vetter <daniel at ffwll.ch> wrote:
>> > pfit_size stores the request mode, which matches crtc->config.requested
>> > mode. Instead of jumping through hoops I think I'd be better to directly
>> > use those values ...
>> Scrap that, I can't read code ;-)
> One change I'd like is to store the pfit window w/h as individual values
> instead of sticking the raw register value into pipe_config. Nothing else
> seems to be stored there in raw form, so it feels inconsistent. And it
> would avoid the mask/shift busniness when extracting the values.

We have a few other cases with raw register values in the pipe_config
already, like some of the pll stuff. But I agree that when we have
some other code using the logical values, it's better to store those.
Maybe something to do as a follow-up.
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

More information about the Intel-gfx mailing list