[Intel-gfx] [PATCH] drm/i915: Restore rps/rc6 on reset

[Jani Nikula]

On Thu, 31 Oct 2013, jeff.mcgee at intel.com wrote:
> From: Jeff McGee <jeff.mcgee at intel.com>
>
> Hello all,
>
> Posting my first patch to the list. I have tested this fix on Android
> kernel 3.9.1 and only compile-checked on drm-intel-nightly. I have
> reviewed the changes to reset and rps/rc6 stuff and believe there
> should be no hidden gotchas.
>
> As I hope this to be the first of many patches to upstream, I will
> probably need a bleeding-edge kernel dev environment to complement
> my Android testing. Any tips on what to use would be appreciated.

It would be awesome if you could run our -nightly kernels on Android,
but I can understand if that's not feasible (missing upstream drivers
etc.)

Otherwise any distro you feel comfortable working with should be
fine. For a start, the userspace doesn't really have to be bleeding edge
(indeed for the most parts I run vanilla userspace from the distro). You
should always be able to switch to a newer kernel without regressing the
userspace.

> I was instructed to keep the JIRA issue codes on the patch, but have
> to wonder why I don't see any of these in the history. Let me know if
> those shouldn't be there.

Personally I don't think references to internal systems provide much
value, though others may disagree. In any case the commit message has to
be self sufficient without the referenced info. (And no complaints about
that in your patch!)

Keep the patches coming! ;)


HTH,
Jani.


>
> Thanks,
> Jeff
>
> Jeff McGee (1):
>   drm/i915: Restore rps/rc6 on reset
>
>  drivers/gpu/drm/i915/i915_debugfs.c | 49 +++++++++++++++++++++++++++++++------
>  drivers/gpu/drm/i915/i915_drv.c     | 11 +++++++++
>  drivers/gpu/drm/i915/intel_pm.c     | 31 ++++++++++++++++-------
>  3 files changed, 74 insertions(+), 17 deletions(-)
>
> -- 
> 1.8.4.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center