[Intel-gfx] [PATCH] drm/i915: Restore rps/rc6 on reset

Daniel Vetter daniel at ffwll.ch
Fri Nov 1 12:05:55 CET 2013


On Fri, Nov 1, 2013 at 11:47 AM, Jani Nikula
<jani.nikula at linux.intel.com> wrote:
>> I was instructed to keep the JIRA issue codes on the patch, but have
>> to wonder why I don't see any of these in the history. Let me know if
>> those shouldn't be there.
>
> Personally I don't think references to internal systems provide much
> value, though others may disagree. In any case the commit message has to
> be self sufficient without the referenced info. (And no complaints about
> that in your patch!)

Yeah, if crucial information is hidden behind internal references
that's not great. And I think for that reason such stuff is a bit
frowned upon. But if it helps you to keep track of the patches I don't
mind. I think the usual approach though is to smash a Changeset-Id:
tag onto the patch and use that to track the patch flow.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list