[Intel-gfx] [PATCH] prime_self_import: Assure no pending requests before object counting

Daniel Vetter daniel at ffwll.ch
Mon Nov 4 18:13:04 CET 2013


On Mon, Nov 4, 2013 at 5:45 PM, Mateo Lozano, Oscar
<oscar.mateo at intel.com> wrote:
> IMHO, gem_quiescent_gpu() does need the drop cache call, otherwise it doesn´t really do what it advertises. However, calling gem_quiescent_gpu() inside get_object_count() is probably overkill, and could potentially mask something going wrong (not so much when called at the beginning of a subtest, but definitely when called at the end!).

Well i-g-t testcase run under the assumption that nothing else does,
so most often the drop_cache call would be a noop. Save when there's
indeed something left to retire, in which case it matters actually.
I'll add it if you don't feel like doing it yourself.
-Danile
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list