[Intel-gfx] [PATCH] prime_self_import: Assure no pending requests before object counting

Mateo Lozano, Oscar oscar.mateo at intel.com
Mon Nov 4 18:26:40 CET 2013


> > IMHO, gem_quiescent_gpu() does need the drop cache call, otherwise it
> doesn´t really do what it advertises. However, calling gem_quiescent_gpu()
> inside get_object_count() is probably overkill, and could potentially mask
> something going wrong (not so much when called at the beginning of a
> subtest, but definitely when called at the end!).
> 
> Well i-g-t testcase run under the assumption that nothing else does, so most
> often the drop_cache call would be a noop. Save when there's indeed
> something left to retire, in which case it matters actually.
> I'll add it if you don't feel like doing it yourself.

It´s ok, I´ll add it. But... which call do you want?:

A) igt_drop_caches_set() inside gem_quiescent_gpu()
B) gem_quiescent_gpu() inside get_object_count()
C) Both of them



More information about the Intel-gfx mailing list