[Intel-gfx] [PATCH] drm/i915: Print RC6 info less often

Chris Wilson chris at chris-wilson.co.uk
Sat Oct 19 13:53:12 CEST 2013

On Fri, Oct 18, 2013 at 12:32:07PM -0700, Ben Widawsky wrote:
> Since we use intel_enable_rc6() now for more than just when we're
> enabling RC6, we'll see this message many times, and it is just
> confusing.

I agree. Ok, had to double check that i915.i915_enable_rc6 was not
writable at runtime, so it looks like the defaults are fixed and so it
is not possible for intel_enable_rc6() to return different values over
its lifetime.
> As an example, calc_residency calls this function whenever poked via
> sysfs. This leaves the impression in dmesg that we're constantly
> re-enabling RC6.
> While at it, move the defines and description from drv.h to intel_pm.c,
> since these are only ever used in that code.
> Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list