[Intel-gfx] [PATCH] drm/i915: Print RC6 info less often
Daniel Vetter
daniel at ffwll.ch
Mon Oct 21 10:05:09 CEST 2013
On Sat, Oct 19, 2013 at 12:53:12PM +0100, Chris Wilson wrote:
> On Fri, Oct 18, 2013 at 12:32:07PM -0700, Ben Widawsky wrote:
> > Since we use intel_enable_rc6() now for more than just when we're
> > enabling RC6, we'll see this message many times, and it is just
> > confusing.
>
> I agree. Ok, had to double check that i915.i915_enable_rc6 was not
> writable at runtime, so it looks like the defaults are fixed and so it
> is not possible for intel_enable_rc6() to return different values over
> its lifetime.
>
> > As an example, calc_residency calls this function whenever poked via
> > sysfs. This leaves the impression in dmesg that we're constantly
> > re-enabling RC6.
> >
> > While at it, move the defines and description from drv.h to intel_pm.c,
> > since these are only ever used in that code.
> >
> > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
More information about the Intel-gfx
mailing list