[Intel-gfx] [PATCH] drm/i915: Move the pipe CRC stuff to other pipe data

Damien Lespiau damien.lespiau at intel.com
Mon Oct 21 22:47:59 CEST 2013


On Mon, Oct 21, 2013 at 09:10:20PM +0200, Daniel Vetter wrote:
> Adding stuff to the bottom of struct drm_i915_driver_private is
> nowadays considered uncool.
> 
> Cc: Damien Lespiau <damien.lespiau at intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>

Ville was suggesting moving the pipe_crc struct into intel_crtc. Might
be even better! But anyway:

Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>

-- 
Damien

> ---
>  drivers/gpu/drm/i915/i915_drv.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index faface9..2e1e884 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1380,6 +1380,10 @@ typedef struct drm_i915_private {
>  	struct drm_crtc *pipe_to_crtc_mapping[3];
>  	wait_queue_head_t pending_flip_queue;
>  
> +#ifdef CONFIG_DEBUG_FS
> +	struct intel_pipe_crc pipe_crc[I915_MAX_PIPES];
> +#endif
> +
>  	int num_shared_dpll;
>  	struct intel_shared_dpll shared_dplls[I915_NUM_PLLS];
>  	struct intel_ddi_plls ddi_plls;
> @@ -1460,10 +1464,6 @@ typedef struct drm_i915_private {
>  	struct i915_dri1_state dri1;
>  	/* Old ums support infrastructure, same warning applies. */
>  	struct i915_ums_state ums;
> -
> -#ifdef CONFIG_DEBUG_FS
> -	struct intel_pipe_crc pipe_crc[I915_MAX_PIPES];
> -#endif
>  } drm_i915_private_t;
>  
>  static inline struct drm_i915_private *to_i915(const struct drm_device *dev)
> -- 
> 1.8.4.rc3
> 



More information about the Intel-gfx mailing list