[Intel-gfx] [PATCH] drm/i915: Move the pipe CRC stuff to other pipe data

Daniel Vetter daniel.vetter at ffwll.ch
Mon Oct 21 22:54:16 CEST 2013

On Mon, Oct 21, 2013 at 10:47 PM, Damien Lespiau
<damien.lespiau at intel.com> wrote:
> On Mon, Oct 21, 2013 at 09:10:20PM +0200, Daniel Vetter wrote:
>> Adding stuff to the bottom of struct drm_i915_driver_private is
>> nowadays considered uncool.
>> Cc: Damien Lespiau <damien.lespiau at intel.com>
>> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> Ville was suggesting moving the pipe_crc struct into intel_crtc. Might
> be even better! But anyway:

We enable interrupts before we allocate the intel_crtc structs. So if
we'd store the CRC stuff in there we'd need to be a bit more paranoid
with clearing hw state (since every time we trust the BIOS we end up
burning our hands). So I think this is safer ...
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

More information about the Intel-gfx mailing list