[Intel-gfx] [PATCH 2/4] drm/i915: Remove WaFbcDisableDpfcClockGating on HSW

Daniel Vetter daniel at ffwll.ch
Mon Oct 28 17:12:08 CET 2013


On Mon, Oct 28, 2013 at 10:22:31AM -0200, Paulo Zanoni wrote:
> 2013/10/27 Daniel Vetter <daniel at ffwll.ch>:
> > On Fri, Oct 25, 2013 at 03:27:50PM -0200, Paulo Zanoni wrote:
> >> 2013/10/24 Ben Widawsky <benjamin.widawsky at intel.com>:
> >> > Production HSW does not need it. I confirmed this with Art.
> >> >
> >> > Signed-off-by: Ben Widawsky <ben at bwidawsk.net>
> >>
> >> I just hope these things don't start uncovering bugs :)
> >>
> >> Reviewed-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
> >
> > Merged the first 2 patches of this series. Not sure what to do with the
> > other two, since fbc is essentially disabled on pre-hsw. And no one seems
> > to really work on it :( So I only see minimal reasons to frob with it ...
> 
> IMHO what you said is another reason to actually merge the other two
> patches, since they make FBC-only WAs be applied only on FBC (e.g.,
> probably never).

Oh, that was just a comment on top since the last 2 patches in this series
are blocked on review comments anyway. I'll pull them in once that's
settled. But maybe it spurs someone to work a bit on fbc ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list