[Intel-gfx] [PATCH 2/2] drm/i915: Set up SDVO encoder type only at detect

[Chris Wilson]

On Mon, Apr 14, 2014 at 07:26:09PM +0200, Egbert Eich wrote:
> Depending on the SDVO output_flags SDVO may have multiple connectors.
> These are all initialized in intel_sdvo_output_setup(). The connector
> that is initialized later will override the encoder_type that has been
> set up by an earlier connector type initialization. Eventually the
> one that comes last wins.
> Eventually when intel_sdvo_detect() is called the active connector is
> determined.
> Delay encoder type initialization until the active connector is known
> and set it to the type that corresponds to this connector.
> 
> Signed-off-by: Egbert Eich <eich at suse.de>

Please kill the redundant encoder->encoder_type = DRM_MODE_ENCODER_NONE
as I think that will help clarify that during init we set the
intel_sdvo->type and then during the detection of the actual connected
output we assign the encoder_type.

Otherwise, lgtm.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre