[Intel-gfx] [PATCH v2] drm/i915: Rename defines for selection of ddi buffer translation slot

Damien Lespiau damien.lespiau at intel.com
Fri Aug 8 14:36:17 CEST 2014


On Fri, Aug 08, 2014 at 05:47:25PM +0530, sonika.jindal at intel.com wrote:
>  	/* Start the training iterating through available voltages and emphasis,
>  	 * testing each value twice. */
> -	for (i = 0; i < ARRAY_SIZE(hsw_ddi_buf_ctl_values) * 2; i++) {
> +	for (i = 0; i < ARRAY_SIZE(hsw_ddi_translations_fdi); i++) {

This is correct but obsfucated. You're actually doing
ARRAY_SIZE(hsw_ddi_translations_fdi) / 2 * 2 and we might as well give
the ARRAY_SIZE(hsw_ddi_translations_fdi) / 2 a proper name like I
suggested.

With that fixed, you can add my:

Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>

-- 
Damien



More information about the Intel-gfx mailing list