[Intel-gfx] [PATCH] drm/i915: Enable vblank interrupts for CRC generation

[Daniel Vetter]

On Mon, Aug 25, 2014 at 02:47:17PM +0100, Chris Wilson wrote:
> On Mon, Aug 25, 2014 at 04:24:56PM +0300, Ville Syrjälä wrote:
> > On Mon, Aug 25, 2014 at 01:28:11PM +0100, Chris Wilson wrote:
> > > Pineview requires this. But this changes the debug API...
> > > 
> > > References: https://bugs.freedesktop.org/show_bug.cgi?id=82280
> > 
> > Isn't this just the same old igt_display bug that it doesn't check
> > that the pipe<->port combination is valid?
> 
> It appeared to be both. I had to set it to use the right pipe for LVDS
> and I had to enable interrupts for it to start reading back the CRC.

What does kms_pipe_crc_basic say on pnv? Otoh I've just tried to run that
and it completely falls over on my i945gm box, so that much for the state
of our test infrastructure.

If we can confirm that we need vblank interrupts to get the pipe crc
delivered I'd like to restrict this to just pnv (or whatever else is
affected) and add a comment explaining why we need vblank interrupts
enabled.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch