[Intel-gfx] [PATCH] drm/i915: Enable vblank interrupts for CRC generation

[Chris Wilson]

On Wed, Aug 27, 2014 at 08:12:23AM +0200, Daniel Vetter wrote:
> On Mon, Aug 25, 2014 at 02:47:17PM +0100, Chris Wilson wrote:
> > On Mon, Aug 25, 2014 at 04:24:56PM +0300, Ville Syrjälä wrote:
> > > On Mon, Aug 25, 2014 at 01:28:11PM +0100, Chris Wilson wrote:
> > > > Pineview requires this. But this changes the debug API...
> > > > 
> > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=82280
> > > 
> > > Isn't this just the same old igt_display bug that it doesn't check
> > > that the pipe<->port combination is valid?
> > 
> > It appeared to be both. I had to set it to use the right pipe for LVDS
> > and I had to enable interrupts for it to start reading back the CRC.
> 
> What does kms_pipe_crc_basic say on pnv? Otoh I've just tried to run that
> and it completely falls over on my i945gm box, so that much for the state
> of our test infrastructure.

Given both of your skepticism, I cleaned out my igt and tested afresh. It
works without the extra vblanks. Apologies for the noise.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre