[Intel-gfx] [PATCH 4/4] backlight-helper: Simplify reading the level from stdin
Chris Wilson
chris at chris-wilson.co.uk
Mon Feb 17 19:42:51 CET 2014
On Mon, Feb 17, 2014 at 01:16:54PM +0100, Hans de Goede wrote:
> Since the helper is a standalone app, the usual xserver rules of not using
> stdio because of signal handling don't apply.
>
> And since the helper does run with elevated rights, it is important to keep
> the code KISS so that it can be audited easily.
>
> This commit replaces the hard to read "raw" read loop with a much simpler
> loop using fgets, improving readability of the code.
Ok, the simplicity of the final code won me over.
Thanks for the patches, pushed.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
More information about the Intel-gfx
mailing list