[Intel-gfx] [PATCH] build: Added -UNDEBUG to tools/Android.mk

[Mateo Lozano, Oscar]

> -----Original Message-----
> From: intel-gfx-bounces at lists.freedesktop.org [mailto:intel-gfx-
> bounces at lists.freedesktop.org] On Behalf Of devon.davies at intel.com
> Sent: Wednesday, January 08, 2014 4:07 PM
> To: intel-gfx at lists.freedesktop.org
> Cc: Davies, Devon
> Subject: [Intel-gfx] [PATCH] build: Added -UNDEBUG to tools/Android.mk
> 
> From: Devon Davies <devon.davies at intel.com>
> 
> NDEBUG is defined by default in Android and causes assert(x) to be defined as
> void(x). This change ensures that asserts work as expected in tools.
> 
> This flag is already inside tests/Android.mk

I discussed and agreed to Devon´s solution with him before, so:
Reviewed-by: Oscar Mateo <oscar.mateo at intel.com>

> Signed-off-by: Devon Davies <devon.davies at intel.com>
> ---
>  tools/Android.mk |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/Android.mk b/tools/Android.mk index 4a19b6c..5bda489
> 100644
> --- a/tools/Android.mk
> +++ b/tools/Android.mk
> @@ -40,7 +40,7 @@ define add_tool
> 
>      LOCAL_CFLAGS += -DHAVE_TERMIOS_H
>      LOCAL_CFLAGS += -DHAVE_STRUCT_SYSINFO_TOTALRAM
> -    LOCAL_CFLAGS += -DANDROID
> +    LOCAL_CFLAGS += -DANDROID -UNDEBUG
>      LOCAL_CFLAGS += -std=c99
>      # FIXME: drop once Bionic correctly annotates "noreturn" on pthread_exit
>      LOCAL_CFLAGS += -Wno-error=return-type
> --
> 1.7.9.5
> 
> ---------------------------------------------------------------------
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx