[Intel-gfx] [PATCH] build: Added -UNDEBUG to tools/Android.mk

Damien Lespiau damien.lespiau at intel.com
Wed Jan 8 18:20:28 CET 2014


On Wed, Jan 08, 2014 at 05:13:28PM +0000, Mateo Lozano, Oscar wrote:
> > -----Original Message-----
> > From: intel-gfx-bounces at lists.freedesktop.org [mailto:intel-gfx-
> > bounces at lists.freedesktop.org] On Behalf Of devon.davies at intel.com
> > Sent: Wednesday, January 08, 2014 4:07 PM
> > To: intel-gfx at lists.freedesktop.org
> > Cc: Davies, Devon
> > Subject: [Intel-gfx] [PATCH] build: Added -UNDEBUG to tools/Android.mk
> > 
> > From: Devon Davies <devon.davies at intel.com>
> > 
> > NDEBUG is defined by default in Android and causes assert(x) to be defined as
> > void(x). This change ensures that asserts work as expected in tools.
> > 
> > This flag is already inside tests/Android.mk
> 
> I discussed and agreed to DevonĀ“s solution with him before, so:
> Reviewed-by: Oscar Mateo <oscar.mateo at intel.com>

Thanks for the patch and review, pushed.

-- 
Damien



More information about the Intel-gfx mailing list