[Intel-gfx] [RFC 11/44] drm/i915: Added scheduler hook into i915_seqno_passed()

Jesse Barnes jbarnes at virtuousgeek.org
Wed Jul 2 20:14:35 CEST 2014


On Thu, 26 Jun 2014 18:24:02 +0100
John.C.Harrison at Intel.com wrote:

> +bool i915_scheduler_is_seqno_in_flight(struct intel_engine_cs *ring,
> +				uint32_t seqno, bool *completed);
> +

In what cases might the return value not match the completed value?  I
guess I'll see in a later patch...

Same comment about the ifdef applies here; looks like you have some
runtime checking in place too, which seems sufficient to me.

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list