[Intel-gfx] [PATCH] drm/i915: Support pf CRC source on haswell transcoder edp

Damien Lespiau damien.lespiau at intel.com
Tue May 27 19:37:20 CEST 2014


On Tue, May 27, 2014 at 10:12:07AM +0200, Daniel Vetter wrote:
> diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> index 0542de982260..6d86820d350b 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -327,6 +327,7 @@ struct intel_crtc_config {
>  		u32 pos;
>  		u32 size;
>  		bool enabled;
> +		bool disallow_bypass;
>  	} pch_pfit;

(haven't tested anything or looked deeply into it, but...)

Having struggled with negative variables in the past, this one really
looks awful. disallow *and* bypass. Can we just have 'force' or similar?

As a side note, pch_pfit isn't really correct these days now (the pch_
part).

-- 
Damien



More information about the Intel-gfx mailing list