[Intel-gfx] [PATCH i-g-t 1/2] tests/kms_force_connector: ensure igt_exit is called at exit

[Thomas Wood]

On 9 October 2014 17:00, Gore, Tim <tim.gore at intel.com> wrote:
>> -----Original Message-----
>> From: Thomas Wood [mailto:thomas.wood at intel.com]
>> Sent: Thursday, October 09, 2014 4:51 PM
>> To: intel-gfx at lists.freedesktop.org
>> Cc: Gore, Tim
>> Subject: [PATCH i-g-t 1/2] tests/kms_force_connector: ensure igt_exit is
>> called at exit
>>
>> Since commit 5782eca (lib/igt_core.c: disable lowmemorykiller during tests),
>> igt_exit needs to be called before the test exits.
>>
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84771
>> Cc: Tim Gore <tim.gore at intel.com>
>> Signed-off-by: Thomas Wood <thomas.wood at intel.com>
>
> Hi Thomas, did you see Paulo's suggestion about replacing igt_assert(connector)
> with igt_require(connector). Does this make sense. I'm not sure if any systems
> truly have no vga "connector", but certainly on my harris beach (ultrabook) there
> Is no externally accessible vga.
> Or perhaps you would prefer that to be a separate commit.

Yes, it's addressed in patch 2 of this series.

>
>   Tim
>
>
>
>
>> ---
>>  tests/kms_force_connector.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/kms_force_connector.c b/tests/kms_force_connector.c
>> index 5b19794..96881c7 100644
>> --- a/tests/kms_force_connector.c
>> +++ b/tests/kms_force_connector.c
>> @@ -116,5 +116,5 @@ main (int argc, char **argv)
>>
>>       drmModeFreeConnector(connector);
>>
>> -     igt_success();
>> +     igt_exit();
>>  }
>> --
>> 2.1.0
>