[Intel-gfx] [PATCH 2/5] drm/i915/dp: Cache EDID for a detection cycle
Daniel Vetter
daniel at ffwll.ch
Wed Sep 3 10:45:24 CEST 2014
On Wed, Sep 03, 2014 at 11:23:09AM +0300, Jani Nikula wrote:
> On Tue, 02 Sep 2014, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > @@ -3819,27 +3819,55 @@ intel_dp_get_edid(struct drm_connector *connector, struct i2c_adapter *adapter)
> > return NULL;
> >
> > return drm_edid_duplicate(intel_connector->edid);
> > - }
> > + } else
> > + return drm_get_edid(&intel_connector->base,
> > + &intel_dp->aux.ddc);
>
> Nitpick, I'd like to see braces on all branches if one branch requires
> them. Also CodingStyle.
This is actually one of the case where I tend to routinely ignore
checkpatch and CodingStyle. We're already super-inconsistent about it at
least, so I'm not terribly fond of enforcing it.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
More information about the Intel-gfx
mailing list