[Intel-gfx] [PATCH 2/5] drm/i915/dp: Cache EDID for a detection cycle

[Chris Wilson]

On Wed, Sep 03, 2014 at 11:23:09AM +0300, Jani Nikula wrote:
> On Tue, 02 Sep 2014, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > @@ -3819,27 +3819,55 @@ intel_dp_get_edid(struct drm_connector *connector, struct i2c_adapter *adapter)
> >  			return NULL;
> >  
> >  		return drm_edid_duplicate(intel_connector->edid);
> > -	}
> > +	} else
> > +		return drm_get_edid(&intel_connector->base,
> > +				    &intel_dp->aux.ddc);
> 
> Nitpick, I'd like to see braces on all branches if one branch requires
> them. Also CodingStyle.

It's one instance where CodingStyle doesn't match a dominant pattern in the kernel.
After all it's a fairly recent addition in 2007 and they haven't won the
flame war yet.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre