[Intel-gfx] [PATCH 2/3] drm/i915: s/seqno/request/ tracking inside objects

[John Harrison]

Will the PPGTT fix be sent out soon? If not, can you just send me a 
quick fix directly?

Also, noticed that in 'submit_execbuf()', if the 'copy_from_user()' call 
fails then it jumps to the error return but does not set 'ret' thus will 
actually return success. Also, there seems to be a mix of 'goto error' 
vs 'return E*'. In general it looks like you do the goto only after 'rq' 
has been allocated but there are a couple of places that do the jump 
with a null 'rq'. The code will cope with trying to put a null rq but it 
seems a bit inconsistent.


Thanks,
John.

On 11/09/2014 07:51, Chris Wilson wrote:
> On Tue, Sep 09, 2014 at 03:14:29PM +0100, John Harrison wrote:
>> I pulled a fresh tree on Monday and applied this set of patches.
>> There were two conflicts. It looks like nightly does not have
>> 'i915_gem_context_setparam_ioctl' yet but the tree the patches came
>> from does. Also, my tree has 'DRM_I915_CTX_BAN_PERIOD' instead of
>> 'ctx->hang_stats.ban_period_seconds'.
> A couple of patches earlier in the week with which I have been using for
> stress testing the hangcheck and capture paths.
>   
>> However, I can only boot if I have both execlists and PPGTT
>> disabled. With just PPGTT enabled, I get continuous GPU hangs and
>> nothing ever gets rendered. With execlists enabled, I get a null
>> pointer dereference in 'execlists_get_ring'. With both disabled, I
>> can boot to an Ubuntu desktop but shortly after it goes pop with
>> 'BUG_ON(obj->active == 0)' in 'i915_gem_object_retire__read'.
> Fixed full-ppgtt, rather trivial oversight. But for lack of hardware
> and simulator, I haven't been able to run on bdw, so execlists is only
> compile tested.
> -Chris
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20140911/d30e3a89/attachment.html>