[Intel-gfx] [PATCH i-g-t] tests/kms_color:Color i-g-t

Daniel Stone daniel at fooishbar.org
Tue Dec 29 03:25:00 PST 2015


Hi Dhanya,

On 29 December 2015 at 03:59, Dhanya Pillai <dhanya.p.r at intel.com> wrote:
>         This patch will verify color correction capability of a display driver.
>         Gamma/CSC/De-gamma for SKL/BXT supported.

The commit message here seems odd, given this:

> +               switch (prop_name) {
> +               case gamma_property_8bit:
> +                       test_pipe_gamma(data, display, output,
> +                                       BDW_8BIT_GAMMA_MAX_VALS, value, pipe1);
> +                       break;
> [...]
> +               case gamma_property_10bit:
> +                       test_pipe_gamma(data, display, output, BDW_10BIT_GAMMA_MAX_VALS, value, pipe1);
> +                       break;
> [...]
> +               case gamma_property_split:
> +                       test_pipe_gamma(data, display, output,
> +                                       BDW_SPLITGAMMA_MAX_VALS, value, pipe1);
> +                       break;
> +               case gamma_property_12bit:
> +                       test_pipe_gamma(data, display, output,
> +                                       BDW_12BIT_GAMMA_MAX_VALS, value, pipe1);
> +                       break;

Surely this only works on BDW?

Also, please see my feedback to Lionel's resubmission of the kernel
series, as I think there are a lot of tests missing.

Cheers,
Daniel


More information about the Intel-gfx mailing list