[Intel-gfx] [PATCH] drm/i915: Initialize primary plane src/dst coords when reading hw state
Ander Conselvan de Oliveira
ander.conselvan.de.oliveira at intel.com
Mon Jan 12 07:36:52 PST 2015
Otherwise setting the rotation property will cause the primary plane to
be disabled, caused by having a 0x0 initial value.
Cc: stable at vger.kernel.org
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87662
Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index d1a4de8..fdea96c 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -13322,6 +13322,23 @@ static bool primary_get_hw_state(struct intel_crtc *crtc)
return I915_READ(DSPCNTR(crtc->plane)) & DISPLAY_PLANE_ENABLE;
}
+static void primary_update_size(struct intel_crtc *crtc)
+{
+ struct intel_plane *primary = to_intel_plane(crtc->base.primary);
+
+ if (!crtc->primary_enabled)
+ return;
+
+ primary->crtc_x = 0;
+ primary->crtc_y = 0;
+ primary->crtc_w = crtc->config.pipe_src_w;
+ primary->crtc_h = crtc->config.pipe_src_h;
+ primary->src_x = 0;
+ primary->src_y = 0;
+ primary->src_w = crtc->config.pipe_src_w << 16;
+ primary->src_h = crtc->config.pipe_src_h << 16;
+}
+
static void intel_modeset_readout_hw_state(struct drm_device *dev)
{
struct drm_i915_private *dev_priv = dev->dev_private;
@@ -13332,6 +13349,7 @@ static void intel_modeset_readout_hw_state(struct drm_device *dev)
int i;
for_each_intel_crtc(dev, crtc) {
+
memset(&crtc->config, 0, sizeof(crtc->config));
crtc->config.quirks |= PIPE_CONFIG_QUIRK_INHERITED_MODE;
@@ -13341,6 +13359,7 @@ static void intel_modeset_readout_hw_state(struct drm_device *dev)
crtc->base.enabled = crtc->active;
crtc->primary_enabled = primary_get_hw_state(crtc);
+ primary_update_size(crtc);
DRM_DEBUG_KMS("[CRTC:%d] hw state readout: %s\n",
crtc->base.base.id,
--
1.9.1
More information about the Intel-gfx
mailing list