> > + > > + dev_priv->rps.efficient_freq *= > > + (IS_SKYLAKE(dev) ? GEN9_FREQ_SCALER : 1); This line seems awkward. I suppose a good compiler could optimize out the multiply by one. I would prefer something like: if(IS_SKYLAKE(dev)) dev_priv->rps.efficient_freq *= GEN9_FREQ_SCALER; -- Tom O'Rourke