[Intel-gfx] [PATCH 1/5] drm/i915/skl: Retrieve the Rpe value from Pcode

[Jani Nikula]

On Wed, 10 Jun 2015, "O'Rourke, Tom" <Tom.O'Rourke at intel.com> wrote:
>> > +
>> > +                       dev_priv->rps.efficient_freq *=
>> > +                               (IS_SKYLAKE(dev) ? GEN9_FREQ_SCALER : 1);
>
> This line seems awkward.  I suppose a good compiler could
> optimize out the multiply by one.
>
> I would prefer something like:
>
> 		if(IS_SKYLAKE(dev))
> 			dev_priv->rps.efficient_freq *= GEN9_FREQ_SCALER;

Agreed,
Jani.

>
> -- Tom O'Rourke
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center