[Intel-gfx] [PATCH v4 00/12] All sort of cdclk stuff

[Jani Nikula]

On Thu, 28 May 2015, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Thu, May 28, 2015 at 04:29:10PM +0100, Damien Lespiau wrote:
>> On Wed, May 27, 2015 at 02:49:38PM -0700, Joe Konno wrote:
>> > Do we have an idea when this patch series will be reviewed? Customers
>> > are awaiting for this to be merged to the drm-intel fd.o repository.
>> 
>> This series is mostly reviewed, all but one patch the HSW CDCLK code.
>> I'm not sure that we want to enable that on HSW as AFAIK changing CDCLK
>> hasn't been validated on that platform.
>> 
>> Next step is for Mika to resend the series with jani's comments I
>> believe?
>
> Yeah.
>
> The other thing I realized (and the reason I didn't realize that most here
> is reviewed) is that the r-b tags magically appeared when resending and
> there seems to never have been a review on the m-l. I don't like when that
> kind of backroom review happens, since it excludes everyone else. Besides
> that I'll simply not noticed it has happened ...

Well, as I mentioned, Mika should've added his Signed-off-by, not
Reviewed-by, when picking up where Ville left off. I'm not sure if much
further review is necessary if the patches have gone through two
developers. So I don't think it's as bad as you imply.

BR,
Jani.


> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Jani Nikula, Intel Open Source Technology Center