[Intel-gfx] [PATCH maintainer-tools] dim: Remove git commit --amend from dim_apply

Ander Conselvan De Oliveira conselvan2 at gmail.com
Fri Nov 13 04:33:39 PST 2015


On Fri, 2015-11-13 at 12:16 +0000, Chris Wilson wrote:
> On Fri, Nov 13, 2015 at 02:05:39PM +0200, Ander Conselvan de Oliveira wrote:
> > Calling git --amend invokes the editor, which will not run if it relies
> > on the terminal for input. So don't do that from dim_apply.
> > 
> > Signed-off-by: Ander Conselvan de Oliveira <
> > ander.conselvan.de.oliveira at intel.com>
> 
> Presumable the ammend is there for a good reason and removing it keeps
> the state dirty? So maybe --amend --no-edit?

I'm fine with that, but I'd like to have a definitive answer to the question
before I resend. Maybe Daniel knows?

Ander



More information about the Intel-gfx mailing list