[Intel-gfx] [PATCH maintainer-tools] dim: Remove git commit --amend from dim_apply
Ville Syrjälä
ville.syrjala at linux.intel.com
Fri Nov 13 04:42:54 PST 2015
On Fri, Nov 13, 2015 at 12:16:59PM +0000, Chris Wilson wrote:
> On Fri, Nov 13, 2015 at 02:05:39PM +0200, Ander Conselvan de Oliveira wrote:
> > Calling git --amend invokes the editor, which will not run if it relies
> > on the terminal for input. So don't do that from dim_apply.
> >
> > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
>
> Presumable the ammend is there for a good reason and removing it keeps
> the state dirty? So maybe --amend --no-edit?
I don't think there's any reason other than Daniel's gvim workflow.
--
Ville Syrjälä
Intel OTC
More information about the Intel-gfx
mailing list